Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change LoadMetricInformation properties from int to double #140

Closed
wants to merge 2 commits into from
Closed

Change LoadMetricInformation properties from int to double #140

wants to merge 2 commits into from

Conversation

gobradovic
Copy link
Contributor

The following properties changed type from int to double
because they were previously incorrectly defined in the
swagger spec.

  • balancingThreshold
  • currentClusterLoad
  • clusterCapacityRemaining
  • nodeBufferPercentage
  • bufferedClusterCapacityRemaining
  • minimumNodeLoad
  • maximumNodeLoad
  • plannedLoadRemoval

Property type change is in principle a breaking change. However,
previous version increment from 4.12.0 to 5.0.0 did not fix all
problems so it was not usable. In that sense, this is considered
a bugfix rather than a new major version (6.0.0).

@gobradovic
Regenerate LoadMetricInformation with double properties
045a2d1
@gobradovic
Increment version 5.0.0 -> 5.0.1 for property type change
f4d3ffc 
Property type change is in principle a breaking change. However,
previous version increment from 4.12.0 to 5.0.0 did not fix all
problems so it was not usable. In that sense, this is considered
a bugfix rather than a new major version (6.0.0).
@gobradovic gobradovic requested a review from olegsych November 4, 2024 14:39
@gobradovic gobradovic closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegsych olegsych Awaiting requested review from olegsych

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gobradovic