Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Refactor chat completion concept samples #9822

Conversation

TaoChenOSU
Copy link
Contributor

@TaoChenOSU TaoChenOSU commented Nov 25, 2024

Motivation and Context

Our chat completion concept samples are not well organized and over-complicated with prompts and different settings.

Description

This PR refactors the samples such that they only capture the essential concepts to the chat completion services. This PR also adds sample usage for all supported chat completion services in Semantic Kernel Python.

Contribution Checklist

@TaoChenOSU TaoChenOSU added python Pull requests for the Python Semantic Kernel samples labels Nov 25, 2024
@TaoChenOSU TaoChenOSU self-assigned this Nov 25, 2024
@TaoChenOSU TaoChenOSU requested a review from a team as a code owner November 25, 2024 23:36
@github-actions github-actions bot changed the title Refactor chat completion concept samples Python: Refactor chat completion concept samples Nov 25, 2024
Copy link
Member

@eavanvalkenburg eavanvalkenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving this, looks great! Only thing that I would like to see added is a simple_chatbot_with_kernel_function that uses a template for the system message, chat history and user input, something like You are a ... {{ chat_history }}{{ user_input }}

python/samples/concepts/chat_completion/simple_chatbot.py Outdated Show resolved Hide resolved
@TaoChenOSU TaoChenOSU added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Nov 27, 2024
Merged via the queue into microsoft:main with commit 8dadef2 Nov 27, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation python Pull requests for the Python Semantic Kernel
Projects
Status: Sprint: Done
Development

Successfully merging this pull request may close these issues.

4 participants