Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually override package-json to version 7 #3968

Merged
merged 4 commits into from
Feb 9, 2023

Conversation

samhristov
Copy link
Contributor

Summary

Package got was updated from 9.6.0 to 12.5.3

Details

The got package dependency(9.6.0) has a security vulnerability.
Using the globalOverrides, forcing got version to 12.5.3 to remove vulnerability

How it was tested

Manual rush install and build

common/config/rush/pnpm-config.json Outdated Show resolved Hide resolved
@TheLarkInn TheLarkInn changed the title Hristovs/got fix Manually override package-json to version 7 Feb 9, 2023
Copy link
Member

@TheLarkInn TheLarkInn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for this fix!

@iclanton iclanton enabled auto-merge February 9, 2023 19:35
@iclanton iclanton merged commit 9661aa2 into microsoft:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rush] Rush is dependent on a version of got(9.6.0) which has a security vulnerability
5 participants