Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose user-defined callables into Python #2054

Merged
merged 17 commits into from
Dec 13, 2024
Merged

Expose user-defined callables into Python #2054

merged 17 commits into from
Dec 13, 2024

Conversation

swernli
Copy link
Collaborator

@swernli swernli commented Dec 6, 2024 •
edited
Loading

This change adds new interop capabilities for the qsharp Python module. Any user-defined global callables with types supported by interop will automatically be surfaced into the qsharp.code module and available for invocation or import directly in Python.

@swernli
Expose user-defined callables into Python
2ba5521 
This change adds new interop capabilities for the qsharp Python module. Any user-defined global callables with types supported by interop will automatically be surfaced into the `qsharp.env` module and available for invocation or import directly in Python.
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 6, 2024
View reviewed changes
pip/tests/test_qsharp.py Fixed Show fixed Hide fixed
pip/tests/test_qsharp.py Fixed Show fixed Hide fixed
pip/tests/test_qsharp.py Fixed Show fixed Hide fixed
pip/tests/test_qsharp.py Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 6, 2024
View reviewed changes
pip/tests/test_qsharp.py Fixed Show fixed Hide fixed
minestarks
minestarks reviewed Dec 7, 2024
View reviewed changes
pip/tests/test_qsharp.py Outdated Show resolved Hide resolved
minestarks
minestarks reviewed Dec 7, 2024
View reviewed changes
pip/src/interpreter.rs Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 7, 2024
View reviewed changes
pip/tests/test_qsharp.py Fixed Show fixed Hide fixed
pip/tests/test_qsharp.py Dismissed Show dismissed Hide dismissed
pip/tests/test_qsharp.py Dismissed Show dismissed Hide dismissed
pip/tests/test_qsharp.py Dismissed Show dismissed Hide dismissed
pip/tests/test_qsharp.py Fixed Show fixed Hide fixed
idavis
idavis reviewed Dec 9, 2024
View reviewed changes
pip/qsharp/_qsharp.py Outdated Show resolved Hide resolved
idavis
idavis reviewed Dec 9, 2024
View reviewed changes
pip/qsharp/_qsharp.py Outdated Show resolved Hide resolved
idavis
idavis reviewed Dec 9, 2024
View reviewed changes
pip/qsharp/env/__init__.py Outdated Show resolved Hide resolved
idavis
idavis reviewed Dec 9, 2024
View reviewed changes
pip/tests/test_qsharp.py Outdated Show resolved Hide resolved
idavis
idavis reviewed Dec 10, 2024
View reviewed changes
pip/src/interpreter.rs Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 10, 2024
View reviewed changes
pip/tests/test_qsharp.py Fixed Show fixed Hide fixed
pip/tests/test_qsharp.py Fixed Show fixed Hide fixed
pip/tests/test_qsharp.py Fixed Show fixed Hide fixed
pip/tests/test_qsharp.py Dismissed Show dismissed Hide dismissed
minestarks
minestarks reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@minestarks minestarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posting another batch of comments, but I need to finish going through the compiler folder. Python side looks good

pip/src/interpreter.rs Show resolved Hide resolved
pip/qsharp/env/__init__.py Outdated Show resolved Hide resolved
pip/qsharp/__init__.py Outdated Show resolved Hide resolved
compiler/qsc_hir/src/global.rs Show resolved Hide resolved
compiler/qsc/src/interpret.rs Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 11, 2024
View reviewed changes
pip/tests/test_qsharp.py Dismissed Show dismissed Hide dismissed
pip/tests/test_qsharp.py Dismissed Show dismissed Hide dismissed
pip/tests/test_qsharp.py Dismissed Show dismissed Hide dismissed
pip/tests/test_qsharp.py Dismissed Show dismissed Hide dismissed
pip/tests/test_qsharp.py Dismissed Show dismissed Hide dismissed
idavis
idavis reviewed Dec 11, 2024
View reviewed changes
pip/qsharp/_qsharp.py Outdated Show resolved Hide resolved
idavis
idavis reviewed Dec 11, 2024
View reviewed changes
pip/src/interpreter.rs Outdated Show resolved Hide resolved
minestarks
minestarks approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@minestarks minestarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I left a lot of comments on the design, approved presuming we'll reach a resolution on those. I think it came together really cleverly - thank you!

@swernli swernli enabled auto-merge December 13, 2024 00:14
@swernli swernli added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit f6e8acf Dec 13, 2024
18 checks passed
@swernli swernli deleted the swernli/python-interop branch December 13, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minestarks minestarks minestarks approved these changes

@idavis idavis idavis approved these changes

@billti billti Awaiting requested review from billti billti is a code owner

@sezna sezna Awaiting requested review from sezna

@ScottCarda-MS ScottCarda-MS Awaiting requested review from ScottCarda-MS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swernli @idavis @minestarks