Skip to content

Commit

Permalink
Bump rust dependency versions (except pyo3, rustc_hash, and `miet…
Browse files Browse the repository at this point in the history
…te`) (#1876)

This PR updates all of our Rust dependencies to their latest versions,
with the exception of:
- `pyo3`, which will require some more work as its API has changed-
- `miette`, which doesn't seem to support wasm on certain platforms
post-v5? Needs more investigation
- `rustc_hash`, which had a breaking change in the order of iteration
over `FxHashMap`s.

Note: we apparently iterate over hashmaps in various places, and then do
snapshot tests on the results. `rustc_hash` changed some iteration
ordering, so updating this dependency caused some expect tests to need
updating. In a perfect world, we'd track down these iterations and make
them deterministic. But, the effort/outcome ratio is so low there, since
iteration order is deterministic within a single version of
`rustc_hash`, I say we just update the expect tests and move on.

I also removed patch-version pins from our `Cargo.toml` where they
existed, since we usually just specify major.minor.


#1886: issue to track updating `pyo3`
#1877:  issue to track updating `rustc_hash`

I'm not sure we want to update `miette` any time soon -- it breaks us in
a big way and we are happy with the current version I think. But we
should have a discussion about that. So I filed #1887 to track that.
  • Loading branch information
sezna authored Aug 26, 2024
1 parent ab72944 commit b2f7ddd
Show file tree
Hide file tree
Showing 2 changed files with 216 additions and 168 deletions.
Loading

0 comments on commit b2f7ddd

Please sign in to comment.