Delay instruction #40
Conversation
|
Side note: I don't understand how the tests passed in the CI 🤔 Locally I ran tests with pyqir 0.8.0 and with a modified version from PR qir-alliance/pyqir#233. As expected, the former fails and the latter passes. Please let me know if you understand more 🙏 |
|
Thanks @jrj-d . What hardware/simulator are you targeting that supports delays with QIR? |
|
Our own :) Sorry for not answering sooner, I really must solve this notification issue on GitHub :) |
|
Sorry for the delay, @jrj-d, I've been thinking about this a bit. I think the best course of action to support what you need is to allow qiskit-qir to be extended allowing users to optionally add gate support. I'll see if I can work something out this week to open up this kind of extension. |
|
Thanks @idavis ! Do you mean the user will be able to provide to |
|
I'm not sure yet. A user would need to be able to either provide a base module with extern definitions or have an opportunity to modify the module. Then being able to opt into defining gates. Perhaps an optional callback that is called given the |
|
Just to make sure I understand correctly: your idea is to make it possible for a user like me to add a |
|
PyQIR is capable of writing any kind of function including being an extern (another sample) or with a body implementation. |
|
Hello @idavis , I hope you're well! Have you been able to think about a proper interface to allow the users to extend qiskit-qir? Thanks! |
|
@jrj-d Sorry, I haven't been able to work on this yet. |
* The backend-dependent time unit dt is left untouched * All other time units (s, ms, us, ns, ps) are converted to us when generating QIR
jrj-d
force-pushed
the
add_delay_instruction
branch
from
96734a9 to
80fe49c
Compare
This is made possible by a temporary fork of qiskit-qir. Discussions to add the delay instruction to the upstream repo (or to let the user define custom translation rules) are engaged in microsoft/qiskit-qir#40
This is made possible by a temporary fork of qiskit-qir. Discussions to add the delay instruction to the upstream repo (or to let the user define custom translation rules) are engaged in microsoft/qiskit-qir#40
This is made possible by a temporary fork of qiskit-qir. Discussions to add the delay instruction to the upstream repo (or to let the user define custom translation rules) are engaged in microsoft/qiskit-qir#40
Hello,
This PR maps the Qiskit delay instruction to the new delay instruction in the QIS introduced in this PR qir-alliance/pyqir#233.
Using the delay instruction, users will be able to do must-have experiments with qubits like T1 measurements, T2 Ramsey measurements, T2 Hahn measurements, etc.
PR #37 should be merged before this one.
Additionally, this PR is blocked by PR qir-alliance/pyqir#233. A new release of pyqir will be required before merging.
Happy to discuss and thanks for considering it!