don't plumb category

microsoft · Oct 25, 2024 · c89488a · c89488a
1 parent 8afe8f6
commit c89488a
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/packages/html-reporter/src/testResultView.tsx b/packages/html-reporter/src/testResultView.tsx
@@ -184,7 +184,7 @@ const StepTreeItem: React.FC<{
   step: TestStep;
   depth: number,
 }> = ({ step, depth }) => {
-  const attachmentName = step.category === 'attach' ? step.title.match(/^attach "(.*)"$/)?.[1] : undefined;
+  const attachmentName = step.title.match(/^attach "(.*)"$/)?.[1];
   return <TreeItem title={<span aria-label={step.title}>
     <span style={{ float: 'right' }}>{msToString(step.duration)}</span>
     {attachmentName && <a style={{ float: 'right' }} title='link to attachment' href={'#' + componentID(params => params.set('attachment', attachmentName))} onClick={(evt) => { evt.stopPropagation(); }}>{icons.attachment()}</a>}

diff --git a/packages/html-reporter/src/types.ts b/packages/html-reporter/src/types.ts
@@ -102,7 +102,6 @@ export type TestResult = {
 
 export type TestStep = {
   title: string;
-  category: 'hook' | 'fixture' | 'test.step' | 'expect' | 'attach' | string;
   startTime: string;
   duration: number;
   location?: Location;

diff --git a/packages/playwright/src/reporters/html.ts b/packages/playwright/src/reporters/html.ts
@@ -498,7 +498,6 @@ class HtmlBuilder {
     const { step, duration, count } = dedupedStep;
     const result: TestStep = {
       title: step.title,
-      category: step.category,
       startTime: step.startTime.toISOString(),
       duration,
       steps: dedupeSteps(step.steps).map(s => this._createTestStep(s)),