chore: add @babel/plugin-proposal-decorators to babelBundle #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
commented
Sep 17, 2024
| @@ -15,10 +15,13 @@ | |||
| */ | |||
|
|
|||
| export { types as t } from '@babel/core'; | |||
| import { parse } from '@babel/parser'; | |||
| import { parse } from '@babel/core'; | |||
There was a problem hiding this comment.
Note: The plugin format between @babel/parser and @babel/core are different, we use the @babel/core one in order to provide similar parsing capabilities compared to upstream Test Runner. We might should re-visit the plugins we add here, so they are aligned with upstream.
mxschmitt
force-pushed
the
add-@babel/plugin-proposal-decorators
branch
from
db489bc to
d076625
Compare
mxschmitt
commented
Sep 17, 2024
| @@ -165,7 +165,7 @@ | |||
| "@typescript-eslint/parser": "^7.3.1", | |||
| "@vscode/l10n-dev": "^0.0.24", | |||
| "@vscode/vsce": "^3.0.0", | |||
| "esbuild": "^0.15.15", | |||
| "esbuild": "^0.23.1", | |||
There was a problem hiding this comment.
I had to update esbuild in order to make it bundle browserslist. Browserslist is a dependency by node_modules/@babel/helper-compilation-targets.
pavelfeldman
approved these changes
Sep 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/playwright#32619