[Feature] IDE mode Trace Viewer #531
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #519 . As @pavelfeldman pointed out, embedding trace viewer in VSCode had usability issues. This PR is an attempt reuse some of the changes made, namely the trace viewer app being backed by the existing testServer, while keep trace viewer as an external app.
Besides, as testServer allows a much richer communication protocol, this PR also improves VS code and trace viewer integration. The following video shows VS code listening to action selection changes in trace viewer and opening the corresponding code:
Recording.2024-09-15.102816.mp4