feat: add toggle for always recreating global setup #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -279,6 +280,12 @@ function htmlForWebview(vscode: vscodeTypes.VSCode, extensionUri: vscodeTypes.Ur | |||
| ${vscode.l10n.t('Show trace viewer')} | |||
| </label> | |||
| </div> | |||
| <div> | |||
There was a problem hiding this comment.
We should move below to the rareActions as it is unlikely that the user needs it.
|
|
||
| if (type === 'setup') { | ||
| if (this._embedder.settingsModel.dontReuseGlobalSetup.get()) | ||
| return true; |
There was a problem hiding this comment.
But even with the rename, I'm not sure what the sematic is. I'd say that the runGlobalSetup/runGlobalTeardown actions should be disabled when I opt into the runGlobalSetupOnEachRun engages.
There was a problem hiding this comment.
I made them hidden instead of disabling, so we remove some more unneeded visual clutter.
pavelfeldman
approved these changes
Aug 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes microsoft/playwright#32121.
Adds an opt-in checkbox called "Don't reuse global setup". When enabled, we'll re-run global setup before every test run.