chore(trace-viewer): support source location external link #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
approved these changes
Aug 16, 2024
|
If 1.47.0-alpha-2024-08-15 contains the feature you can roll it as a part of the same change. |
ruifigueira
force-pushed
the
feat/open-source-location-embedded-trace-viewer
branch
from
5b5b20c to
90f6008
Compare
|
1.47.0-alpha-2024-08-17 already includes it. |
pavelfeldman
approved these changes
Aug 20, 2024
Skn0tt
added a commit
to Skn0tt/playwright-vscode
that referenced
this pull request
Nov 11, 2024
…icrosoft#517)" This reverts commit d5398f7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: microsoft/playwright#32175
I'll leave it in draft because it requires that
@playwright/testdependency to be updated to a version that includes microsoft/playwright@b2ccfc3