Convert mocked VSCode tests into integration tests PoC #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vscodeTest.ts has core vscode playwright integration, extension agnostic baseTest.ts has playwright-vscode integration functions
ruifigueira
changed the title
|
Could you help me understand how you intend to be using this? We already have a test harness that scales well enough to allow for large number of tests with options matrices. The idea behind the integration tests is that extension does not fail miserably in the production, they were not intended to be used for correctness testing. |
|
It was just an exercise, to see if it was feasible. When I was extending the mocked vscode for the embedded trace viewer, I wondered if it was possible to use vscode itself. I then realized that you already had those integration tests, and so I just tried to fill the gaps. |
|
I'll close it as outside of the scope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a small test framework on top of VSCode extension testing runner and playwright tests, extending the existing tests-integration suite.
The main idea is to be able to evaluate VSCode-side code from playwright tests, in a similar way as Page.evaluate / Page.evaluateHandle. Besides, I also introduced the
VSCodeHandleto keep remote references to VSCode objects that those functions may return, as well as registering local listeners over remoteEventEmitters.Another nice thing with this approach is that using a library as
sinon(I use it to decorate some vscode behaviour) is as simple as installing it withnpm installand dynamically import it in the VSCode function to evaluate.With all this, I was able to create proxies with similar API to the existing mocked VSCode and converting test specs to use the integration library is as easy as changing the import, basically.