Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set minimum Playwright version to v1.38 #487

Merged
merged 2 commits into from
Jun 12, 2024
Merged

chore: set minimum Playwright version to v1.38 #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2bfa7d
chore: bump minimum Playwright extension
mxschmitt May 22, 2024
84551c3
Update README.md
mxschmitt May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@ This extension integrates Playwright into your VS Code workflow. Here is what it

### Requirements

This extension works with [Playwright] version v1.19+ or newer.
This extension works with [Playwright] version v1.38+ or newer.

*If you are looking for the old extension that supported Playwright v1.14+, switch to v0.0.9 of this extension manually. Having said that, we highly recommend using the latest version of [Playwright]!*

## Install Playwright

Expand Down
2 changes: 1 addition & 1 deletion src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ export class Extension implements RunHooks {
continue;
}

const minimumPlaywrightVersion = 1.28;
const minimumPlaywrightVersion = 1.38;
if (playwrightInfo.version < minimumPlaywrightVersion) {
if (userGesture) {
this._vscode.window.showWarningMessage(
Expand Down