Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(debug): use full config file when debugging #482

Merged
merged 1 commit into from
May 17, 2024
+6 −4
Merged

fix(debug): use full config file when debugging #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"displayName": "Playwright Test for VSCode",
"description": "%description%",
"icon": "images/playwright-logo.png",
"version": "1.1.2",
"version": "1.1.3",
"publisher": "ms-playwright",
"repository": "https://github.com/microsoft/playwright-vscode",
"bugs": {
Expand Down
4 changes: 3 additions & 1 deletion src/playwrightTestServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,9 @@ export class PlaywrightTestServer {
}

async debugTests(items: vscodeTypes.TestItem[], runOptions: PlaywrightTestRunOptions, reporter: reporterTypes.ReporterV2, token: vscodeTypes.CancellationToken): Promise<void> {
const configFile = path.basename(this._model.config.configFile);
// Important, VSCode will change c:\\ to C:\\ in the program argument.
// This forks globals into 2 worlds.
const configFile = path.resolve(this._model.config.workspaceFolder, this._model.config.configFile);
const args = ['test-server', '-c', configFile];

const addressPromise = new Promise<string>(f => {
Expand Down