Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove internal options, enable watch #464

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

pavelfeldman
Copy link
Member

No description provided.

if (model)
return model;
return this._models.find(m => m.isEnabled);
this._selectedConfigFile = enabledModels[0].config.configFile;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating in a getter sounds strange! Perhaps the method that enables/disables a model should update this field? Or default to a first enabled model when this._selectedConfigFile points nowhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or default to a first enabled model when this._selectedConfigFile points nowhere?

That's what it was, but in that case picking new model will change the current selection in the UI, which does not sound friendly. Think about this assignment here as a cache.

@pavelfeldman pavelfeldman merged commit 7e5ae71 into microsoft:main Apr 25, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants