chore: move debug to test server #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Mar 31, 2024
| FORCE_COLOR: '1', | ||
| PW_TEST_SOURCE_TRANSFORM: require.resolve('./debugTransform'), | ||
| PW_TEST_SOURCE_TRANSFORM_SCOPE: testDirs.join(pathSeparator), | ||
| }, |
There was a problem hiding this comment.
We pass PWDEBUG: 'console' in the cli mode, but not here?
There was a problem hiding this comment.
I forgot what it stands for. It means browser console, so it should be in. Added.
| projects: projects.length ? projects.map(p => p.name).filter(Boolean) : undefined, | ||
| headed: !this._options.isUnderTest, | ||
| workers: 1, | ||
| trace: 'off', |
There was a problem hiding this comment.
I am probably missing it, but where was trace: 'off' in the old code?
There was a problem hiding this comment.
There was no trace off in the old code, I can add it though.
src/playwrightTestCLI.ts
Outdated
| '--repeat-each', '1', | ||
| '--retries', '0', | ||
| '--timeout', '0', | ||
| '--workers', '1' |
There was a problem hiding this comment.
Shouldn't we read these options from options instead of hardcoding them?
There was a problem hiding this comment.
Only workers and headed are a part of PlaywrightTestRunOptions, the rest are hard-coded.
src/playwrightTestServer.ts
Outdated
| ...process.env, | ||
| CI: this._options.isUnderTest ? undefined : process.env.CI, | ||
| ...this._options.envProvider(), | ||
| PW_TEST_CONNECT_WS_ENDPOINT: testOptions.connectWsEndpoint, |
There was a problem hiding this comment.
Shouldn't this go over protocol now?
pavelfeldman
force-pushed
the
debug_server
branch
from
fed18c9 to
3401e6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.