fix: error handling on list-files (#441)

microsoft · Mar 15, 2024 · f92ad70 · f92ad70
1 parent 75a2022
commit f92ad70
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/playwrightTest.ts b/src/playwrightTest.ts
@@ -109,8 +109,12 @@ export class PlaywrightTest {
       this._log(`${escapeRegex(path.relative(config.workspaceFolder, configFolder))}> playwright list-files -c ${configFile}`);
     }
     const output = await this._runNode(allArgs, configFolder);
-    const result = JSON.parse(output) as ConfigListFilesReport;
-    return result;
+    const result = JSON.parse(output) as Partial<ConfigListFilesReport>;
+    return {
+      // list-files does not return `projects: []` if there is an error.
+      projects: [],
+      ...result,
+    };
   }
 
   private async _listFilesServer(config: TestConfig): Promise<ConfigListFilesReport> {

diff --git a/src/testModel.ts b/src/testModel.ts
@@ -396,7 +396,8 @@ export class TestModelCollection extends DisposableBase {
         firstProject = false;
       }
     } else {
-      model.projects()[0].isEnabled = true;
+      if (model.projects().length)
+        model.projects()[0].isEnabled = true;
     }
   }