fix: ensure TestModelCollection is disposed

microsoft · Jul 31, 2024 · 27684b6 · 27684b6
1 parent 3c8c31e
commit 27684b6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/extension.ts b/src/extension.ts
@@ -228,6 +228,7 @@ export class Extension implements RunHooks {
       this._reusedBrowser,
       this._diagnostics,
       this._treeItemObserver,
+      this._models,
       registerTerminalLinkProvider(this._vscode),
     ];
     const fileSystemWatchers = [

diff --git a/src/testModel.ts b/src/testModel.ts
@@ -709,10 +709,14 @@ export class TestModelCollection extends DisposableBase {
 
   clear() {
     this.dispose();
+    this._didUpdate.fire();
+  }
+
+  dispose() {
+    super.dispose();
     for (const model of this._models)
       model.reset();
     this._models = [];
-    this._didUpdate.fire();
   }
 
   enabledModels(): TestModel[] {