chore: roll to v1.49.0 #2660
Merged
chore: roll to v1.49.0 #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
commented
Nov 21, 2024
| match = glob_to_regex(match) | ||
| if isinstance(match, Pattern): | ||
| return bool(match.search(url_string)) | ||
| return match(url_string) |
There was a problem hiding this comment.
For some reason Python does not have this code:
The "past path" seems an optimisation while the 'parseURL path matching' seems not implemented at all?
There was a problem hiding this comment.
It seems like js has some dead code. match cannot be a string there because we do match = globToRegex(match); before.
mxschmitt
commented
Nov 21, 2024
mxschmitt
commented
Nov 21, 2024
dgozman
approved these changes
Nov 21, 2024
| match = glob_to_regex(match) | ||
| if isinstance(match, Pattern): | ||
| return bool(match.search(url_string)) | ||
| return match(url_string) |
There was a problem hiding this comment.
It seems like js has some dead code. match cannot be a string there because we do match = globToRegex(match); before.
mxschmitt
force-pushed
the
roll/v1.49
branch
from
0a44a70
to
04fe1c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2606
Fixes #1949