-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IR][fix] Save value info for initializers #1552
base: main
Are you sure you want to change the base?
Conversation
❌ 9 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
Test Results 24 files ± 0 24 suites ±0 42m 4s ⏱️ - 2h 46m 54s For more details on these failures, see this check. Results for commit 64e740a. ± Comparison against base commit 9bae2b5. This pull request removes 9868 and adds 6038 tests. Note that renamed tests count towards both.
This pull request removes 14 skipped tests and adds 2018 skipped tests. Note that renamed tests count towards both.
This pull request skips 16 and un-skips 8 tests.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ci fails
if not initializer_name: | ||
logger.warning( | ||
"Initializer tensor must have a name but the %s-th initializer does not. Skipping this initializer.", | ||
i, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we indicate it's index? Like f"initiliizer[{i}]"
Can this be closed, or is this still relevant? |
This is still relavent. We need to update our test data first. |
Previously initializers are not included in the graph value_info because they are not easily accessible from the Graph object. Now what we store all the Values for initializers, we can serialize the value information into the graph.
Fix #1501