Merged PR 1192: Fixing WebDependency urllib.request error on Linux

With just `import urllib`, the modules inside urllib were not imported. We will now be importing urllib.request and urllib.error directly so they can be used consistently.
microsoft · May 22, 2019 · 211526a · 211526a
1 parent 47b9c9d
commit 211526a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/MuEnvironment/WebDependency.py b/MuEnvironment/WebDependency.py
@@ -29,7 +29,8 @@
 import shutil
 import tarfile
 import zipfile
-import urllib
+import urllib.error
+import urllib.request
 from MuEnvironment.ExternalDependency import ExternalDependency
 
 

diff --git a/MuEnvironment/tests/test_WebDependency.py b/MuEnvironment/tests/test_WebDependency.py
@@ -32,6 +32,7 @@
 import tarfile
 import zipfile
 import tempfile
+import urllib.request
 from MuEnvironment import EnvironmentDescriptorFiles as EDF
 from MuEnvironment.WebDependency import WebDependency
 
@@ -94,7 +95,7 @@ def test_fail_with_bad_url(self):
 
         ext_dep_descriptor = EDF.ExternDepDescriptor(ext_dep_file_path).descriptor_contents
         ext_dep = WebDependency(ext_dep_descriptor)
-        with self.assertRaises(Exception):
+        with self.assertRaises(urllib.error.HTTPError):
             ext_dep.fetch()
             self.fail("should have thrown an Exception")