Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select algo according to json config #396

Merged
merged 10 commits into from
Dec 3, 2024
Merged

Select algo according to json config #396

merged 10 commits into from
Dec 3, 2024

Conversation

Binyang2014
Copy link
Contributor

@Binyang2014 Binyang2014 commented Dec 1, 2024

The way to run nccl-test over mscclpp:
mpirun -np 8 --bind-to numa --allow-run-as-root -x LD_PRELOAD=$(pwd)/build/apps/nccl/libmscclpp_nccl.so -x NCCL_DEBUG=WARN -x MSCCLPP_EXECUTION_PLAN_DIR=/execution-files /root/nccl-tests/build/all_reduce_perf -b 1K -e 1G -f 2 -d half -G 20 -w 10 -n 20

@Binyang2014 Binyang2014 marked this pull request as ready for review December 3, 2024 02:59
Copy link
Contributor

@chhwang chhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/include/execution_plan.hpp Outdated Show resolved Hide resolved
apps/nccl/src/nccl.cu Outdated Show resolved Hide resolved
apps/nccl/src/nccl.cu Show resolved Hide resolved
@Binyang2014 Binyang2014 enabled auto-merge (squash) December 3, 2024 06:35
apps/nccl/src/nccl.cu Outdated Show resolved Hide resolved
Copy link
Contributor

@caiomcbr caiomcbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Binyang2014 Binyang2014 merged commit 88d28e0 into main Dec 3, 2024
20 checks passed
@Binyang2014 Binyang2014 deleted the binyli/nccl branch December 3, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants