Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CMake options #376

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Improve CMake options #376

merged 5 commits into from
Nov 22, 2024

Conversation

chhwang
Copy link
Contributor

@chhwang chhwang commented Oct 30, 2024

  • Let all CMake option names start with MSCCLPP_
  • Explain the MSCCLPP_BUILD_PYTHON_BINDINGS option in readme

@chhwang chhwang requested a review from Binyang2014 November 10, 2024 01:28
@chhwang chhwang enabled auto-merge (squash) November 22, 2024 01:03
@chhwang chhwang merged commit 2127a3b into main Nov 22, 2024
20 checks passed
@chhwang chhwang deleted the chhwang/fix-cmake branch November 22, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Binyang2014 Binyang2014 Binyang2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chhwang @Binyang2014