Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPKit exit event offset #356

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix NPKit exit event offset #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/mscclpp/npkit/npkit_event.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
#define NPKIT_EVENT_EXECUTOR_INIT_EXIT 0x4

#define NPKIT_EVENT_EXECUTOR_OP_BASE_ENTRY 0x5
#define NPKIT_EVENT_EXECUTOR_OP_BASE_EXIT 0x15
#define NPKIT_EVENT_EXECUTOR_OP_BASE_EXIT 0x17

#endif
4 changes: 2 additions & 2 deletions src/include/execution_common.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ enum class OperationType : uint8_t {
BARRIER,
PUT,
PUT_PACKET,
PUT_WITH_SIGNAL,
PUT_WITH_SIGNAL_AND_FLUSH,
GET,
COPY,
COPY_PACKET,
Expand All @@ -44,8 +46,6 @@ enum class OperationType : uint8_t {
REDUCE_SEND_PACKET,
READ_REDUCE_COPY,
READ_REDUCE_COPY_SEND,
PUT_WITH_SIGNAL,
PUT_WITH_SIGNAL_AND_FLUSH,
};

struct Channels {
Expand Down
4 changes: 2 additions & 2 deletions tools/npkit/npkit_trace_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ def parse_npkit_event_header(npkit_event_header_path):
"BARRIER",
"PUT",
"PUT_PACKET",
"PUT_WITH_SIGNAL",
"PUT_WITH_SIGNAL_AND_FLUSH",
"GET",
"COPY",
"COPY_PACKET",
Expand All @@ -27,8 +29,6 @@ def parse_npkit_event_header(npkit_event_header_path):
"REDUCE_SEND_PACKET",
"READ_REDUCE_COPY",
"READ_REDUCE_COPY_SEND",
"PUT_WITH_SIGNAL",
"PUT_WITH_SIGNAL_AND_FLUSH",
]
executor_op_to_offset = {}
for executor_op in executor_ops:
Expand Down
Loading