Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add executor to execute schedule-plan file #283

Merged
merged 54 commits into from
Apr 18, 2024
Merged

Add executor to execute schedule-plan file #283

merged 54 commits into from
Apr 18, 2024

Conversation

Binyang2014
Copy link
Contributor

Add executor to execute the JSON schedule file generated by msccl-tools

@Binyang2014 Binyang2014 marked this pull request as ready for review April 9, 2024 08:03
@Binyang2014 Binyang2014 requested review from chhwang and yzygitzh April 9, 2024 08:04
chhwang
chhwang requested changes Apr 17, 2024
View reviewed changes
src/executor/execution_kernel.cu Show resolved Hide resolved
src/executor/execution_plan.cc Outdated Show resolved Hide resolved
include/mscclpp/executor.hpp Outdated Show resolved Hide resolved
include/mscclpp/packet_device.hpp Outdated Show resolved Hide resolved
python/test/test_mscclpp.py Outdated Show resolved Hide resolved
src/include/execution_common.hpp Show resolved Hide resolved
test/executor_test.cc Outdated Show resolved Hide resolved
chhwang
chhwang approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@chhwang chhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chhwang chhwang enabled auto-merge (squash) April 18, 2024 18:20
@chhwang chhwang mentioned this pull request Apr 18, 2024
Closed
@chhwang chhwang merged commit 64d837f into main Apr 18, 2024
15 checks passed
@chhwang chhwang deleted the binyli/executor branch April 18, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chhwang chhwang chhwang approved these changes

@yzygitzh yzygitzh Awaiting requested review from yzygitzh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Binyang2014 @chhwang