Allow MSCCL++ CommGroup to take PyTorch tensors in args #255
+45
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aashaka
force-pushed
the
aashaka/comm_add_pytorch
branch
from
6bdd9c4 to
d0249a3
Compare
Binyang2014
reviewed
Feb 1, 2024
aashaka
force-pushed
the
aashaka/comm_add_pytorch
branch
from
d0249a3 to
ca5d5f5
Compare
Obtain data_ptr and tensor_size accordingly. Does not depend on torch package.
aashaka
force-pushed
the
aashaka/comm_add_pytorch
branch
from
ca5d5f5 to
85a998d
Compare
chhwang
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obtain data_ptr and tensor_size accordingly for torch.Tensor