Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align interfaces of put/get/putPackets/getPackets #185

Merged
merged 15 commits into from
Oct 7, 2023
Merged

Align interfaces of put/get/putPackets/getPackets #185

merged 15 commits into from
Oct 7, 2023

Conversation

chhwang
Copy link
Contributor

@chhwang chhwang commented Sep 13, 2023

No description provided.

@chhwang chhwang marked this pull request as ready for review September 13, 2023 15:17
@chhwang chhwang linked an issue Sep 13, 2023 that may be closed by this pull request
[Feature] getPacket arg list does not match the get function from sm_channels #158
Closed
saeedmaleki
saeedmaleki approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@saeedmaleki saeedmaleki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think origin and target will be the best choices. Would you agree?

include/mscclpp/sm_channel_device.hpp Outdated Show resolved Hide resolved
@chhwang
Copy link
Contributor Author

chhwang commented Oct 7, 2023

This PR is manually tested.
Unit Tests: https://github.com/microsoft/mscclpp/actions/runs/6441276576
Integration Tests: https://github.com/microsoft/mscclpp/actions/runs/6441277737

@chhwang chhwang merged commit 11ac824 into main Oct 7, 2023
13 of 19 checks passed
@chhwang chhwang deleted the chhwang/put-get-interface branch October 7, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olsaarik olsaarik olsaarik approved these changes

@saeedmaleki saeedmaleki saeedmaleki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] getPacket arg list does not match the get function from sm_channels
3 participants
@chhwang @saeedmaleki @olsaarik