Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve single node allreduce performance #169

Merged
merged 12 commits into from
Sep 13, 2023
Merged

Improve single node allreduce performance #169

merged 12 commits into from
Sep 13, 2023

Conversation

Binyang2014
Copy link
Contributor

@Binyang2014 Binyang2014 commented Sep 4, 2023 •
edited
Loading

Improve all reduce performance for single node.
New number:

n_ctx size target latency (us) allreduce5 allreduce6
1 24.0kB 7.7 7.23
2 48.0kB 7.7 7.69
4 96.0kB 8 8.34
8 192.0kB 12.6 9.75
12 288.0kB 13 11.34
16 384.0kB 13.3 12.99
768 18.0MB 158.7 160.3
896 21.0MB 184.5 183.8
1024 24.0MB 209.5 207.5
1152 27.0MB 234.3 231.9
1280 30.0MB 260 255.6
1408 33.0MB 284.9 278.7
1536 36.0MB 310.3 302.0
1664 39.0MB 336.2 325.3
1792 42.0MB 361.4 348.8
1920 45.0MB 384.6 372.2
2048 48.0MB 409.1 395.4

@Binyang2014 Binyang2014 linked an issue Sep 6, 2023 that may be closed by this pull request
[Performance] Improve single-node AllReduce latency #164
Closed
@Binyang2014 Binyang2014 marked this pull request as ready for review September 6, 2023 06:50
saeedmaleki
saeedmaleki approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@saeedmaleki saeedmaleki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @Binyang2014

@chhwang chhwang enabled auto-merge (squash) September 13, 2023 13:49
@chhwang chhwang merged commit 952f2da into main Sep 13, 2023
14 of 16 checks passed
@chhwang chhwang deleted the binyli/allreduce branch September 13, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saeedmaleki saeedmaleki saeedmaleki approved these changes

@chhwang chhwang chhwang approved these changes

@olsaarik olsaarik Awaiting requested review from olsaarik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Performance] Improve single-node AllReduce latency
3 participants
@Binyang2014 @chhwang @saeedmaleki