Skip to content

Commit

Permalink
tackle warnings from clang
Browse files Browse the repository at this point in the history
  • Loading branch information
amduser committed Nov 24, 2023
1 parent 20f0bbd commit df5f616
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion include/mscclpp/core.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ class TcpBootstrap : public Bootstrap {

private:
// The interal implementation.
struct Impl;
class Impl;

// Pointer to the internal implementation.
std::unique_ptr<Impl> pimpl_;
Expand Down Expand Up @@ -401,6 +401,8 @@ class Endpoint {
/// Represents a connection between two processes.
class Connection {
public:
virtual ~Connection() = default;

/// Write data from a source @ref RegisteredMemory to a destination @ref RegisteredMemory.
///
/// @param dst The destination @ref RegisteredMemory.
Expand Down Expand Up @@ -525,6 +527,8 @@ class Context {

/// A base class for objects that can be set up during @ref Communicator::setup().
struct Setuppable {
virtual ~Setuppable() = default;

/// Called inside @ref Communicator::setup() before any call to @ref endSetup() of any @ref Setuppable object that is
/// being set up within the same @ref Communicator::setup() call.
///
Expand Down

0 comments on commit df5f616

Please sign in to comment.