address comments

microsoft · Dec 7, 2024 · 0e6af86 · 0e6af86
1 parent 5ebc412
commit 0e6af86
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/pyproject.toml b/pyproject.toml
@@ -10,7 +10,7 @@ name = "mscclpp"
 version = "0.5.2"
 
 [tool.scikit-build]
-cmake.minimum-version = "3.25.0"
+cmake.version = ">=3.25.0"
 build-dir = "build/{wheel_tag}"
 wheel.packages = ["python/mscclpp", "python/mscclpp_benchmark"]
 wheel.install-dir = "mscclpp"

diff --git a/python/requirements_cuda12.txt b/python/requirements_cuda12.txt
@@ -5,4 +5,5 @@ netifaces
 pytest
 numpy
 matplotlib
+# scikit-build issue, need to fix
 ninja
-Original file line number
+Diff line change
@@ Expand Up / @@ -5,4 +5,5 @@ netifaces @@
     pytest
     numpy
     matplotlib
+    # scikit-build issue, need to fix
     ninja