Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add IpynbConverter #71

Merged
merged 7 commits into from
Dec 17, 2024
Merged

feat: Add IpynbConverter #71

merged 7 commits into from
Dec 17, 2024

Conversation

AumGupta
Copy link
Contributor

  • Implemented IpynbConverter class for converting Jupyter Notebook (.ipynb) files into Markdown format.
  • Supports markdown cells, code cells and raw cells.
  • First markdown heading is used as the title if no title is found in notebook metadata.
  • Created a test notebook (test_notebook.ipynb) to verify the functionality of the converter.

- Implemented IpynbConverter class for converting Jupyter Notebook (.ipynb) files into Markdown format.
- Supports markdown cells, code cells and raw cells.
- First markdown heading is used as the title if no title is found in notebook metadata.
- Created a test notebook (`test_notebook.ipynb`) to verify the functionality of the converter.
@AumGupta
Copy link
Contributor Author

@microsoft-github-policy-service agree

@afourney
Copy link
Member

This is pretty cool, and I like that it doesn't really add any new dependencies (since it's all just json).

@afourney
Copy link
Member

Looks like a small formatting error.

Can you do a:

pre-commit install
pre-commit run --all-files

And then re-commit / push _markitdown.py? Very likely, the formatting will be corrected automatically.

@AumGupta
Copy link
Contributor Author

Looks like a small formatting error.

Can you do a:

pre-commit install
pre-commit run --all-files

And then re-commit / push _markitdown.py? Very likely, the formatting will be corrected automatically.

@afourney brother, I've done it.

@afourney afourney merged commit 7900314 into microsoft:main Dec 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants