Skip to content

Commit

Permalink
Removed UserSecrets, fixed Qdrant test
Browse files Browse the repository at this point in the history
  • Loading branch information
alkampfergit committed Sep 3, 2024
1 parent 3d0e39a commit eebb3db
Show file tree
Hide file tree
Showing 8 changed files with 6 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
<UserSecretsId>31bdda67-28ce-4ba2-b3e7-0eca5d687404</UserSecretsId>
</PropertyGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
<UserSecretsId>3e71ea16-d53c-41a5-9202-c3f264cf1c24</UserSecretsId>
</PropertyGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
<NoWarn>$(NoWarn);KMEXP03;</NoWarn>
<UserSecretsId>5c3c9f0a-6e03-4606-a578-d527359baf3c</UserSecretsId>
</PropertyGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
<NoWarn>$(NoWarn);KMEXP03;</NoWarn>
<UserSecretsId>d2183ec2-a100-438a-a421-3afbde9ca357</UserSecretsId>
</PropertyGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
<UserSecretsId>0949f934-f2b3-477e-ae68-0cc18854ac49</UserSecretsId>
</PropertyGroup>

<ItemGroup>
Expand Down
11 changes: 6 additions & 5 deletions extensions/Qdrant/Qdrant.UnitTests/ScrollVectorsRequestTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

using System.Text.Json;
using Microsoft.KernelMemory.MemoryDb.Qdrant.Client.Http;
using Microsoft.KernelMemory.MemoryDb.Qdrant.Internals;
using Microsoft.KM.TestHelpers;
using Xunit.Abstractions;

Expand Down Expand Up @@ -92,11 +93,11 @@ public void FiltersAreRenderedToJson()
// Arrange
var request = ScrollVectorsRequest
.Create("coll")
.HavingAllTags(["user:devis", "type:blog"])
.HavingAllTags([new TagFilter("user:devis", TagFilterType.Equal), new TagFilter("type:blog", TagFilterType.Equal)])
.HavingSomeTags(new[]
{
new[] { "month:january", "year:2000" },
new[] { "month:july", "year:2003" },
new[] { new TagFilter("month:january", TagFilterType.Equal), new TagFilter("year:2000", TagFilterType.Equal), },
new[] { new TagFilter("month:july", TagFilterType.Equal), new TagFilter("year:2003", TagFilterType.Equal), },
});

// Act
Expand Down Expand Up @@ -157,8 +158,8 @@ public void ItRendersOptimizedConditions()
// Arrange
var request = ScrollVectorsRequest
.Create("coll")
.HavingAllTags(["user:devis", "type:blog"])
.HavingSomeTags([new[] { "month:january", "year:2000" }]);
.HavingAllTags([new TagFilter("user:devis", TagFilterType.Equal), new TagFilter("type:blog", TagFilterType.Equal)])
.HavingSomeTags([new[] { new TagFilter("month:january", TagFilterType.Equal), new TagFilter("year:2000", TagFilterType.Equal) }]);

// Act
var actual = JsonSerializer.Serialize(request);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
<UserSecretsId>effd2045-16ee-4074-9a5a-3d44a9a04512</UserSecretsId>
</PropertyGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
<UserSecretsId>dc812b99-0225-430d-8ff3-6dbf7e48c0bd</UserSecretsId>
</PropertyGroup>

<ItemGroup>
Expand Down

0 comments on commit eebb3db

Please sign in to comment.