This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Changing C# codegen to happen synch. #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgranade
approved these changes
Mar 24, 2022
|
/azp run |
1 similar comment
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ricardo-espinoza
pushed a commit
that referenced
this pull request
Mar 26, 2022
* Changing C# codegen to happen synch. * Be more explicit about workspace init failures. * Propagate internal errors through to logging infrastructure. * Remove debug code. Co-authored-by: Cassandra Granade <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #630 by making the c# codegen calls synchronous (as it turns out, codegen is not threadsafe, see microsoft/qsharp-compiler#1393).
I also moved the codegen to happen after we're building the manifests, as that can happen concurrently.