This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 57
Initial Support for microsoft.simulator Targets on Jupyter Notebooks #601
Merged
ScottCarda-MS
merged 54 commits into
feature/microsoft-qir-v2
from
sccarda/implement-qsharp-submitter
Mar 22, 2022
Merged
Initial Support for microsoft.simulator Targets on Jupyter Notebooks #601
ScottCarda-MS
merged 54 commits into
feature/microsoft-qir-v2
from
sccarda/implement-qsharp-submitter
Mar 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottCarda-MS
changed the title
???
Initial Support for microsoft.simulator Targets on Jupyter Notebooks
Mar 2, 2022
ScottCarda-MS
commented
Mar 4, 2022
cesarzc
reviewed
Mar 11, 2022
cesarzc
reviewed
Mar 11, 2022
cesarzc
reviewed
Mar 11, 2022
cesarzc
reviewed
Mar 11, 2022
cesarzc
reviewed
Mar 11, 2022
cesarzc
reviewed
Mar 11, 2022
cesarzc
reviewed
Mar 11, 2022
cgranade
reviewed
Mar 16, 2022
cesarzc
reviewed
Mar 21, 2022
cesarzc
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just left a couple of suggestions on how to make the filtering of Microsoft targets easier to understand. Other than that, looks great to me!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the
%azure.target
to be set tomicrosoft.simulator.fullstate
in notebooks. This allows QIR generated from notebooks to be submitted to the full state simulator on azure quantum.