change fn names

microsoft · Oct 21, 2024 · 42d120f · 42d120f
1 parent c6d7aed
commit 42d120f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/app/workflows/compare_case_groups/workflow.py b/app/workflows/compare_case_groups/workflow.py
@@ -180,7 +180,7 @@ def create(sv: gn_variables.SessionVariables, workflow=None):
                         value=sv.case_groups_top_groups.value,
                     )
                 fdf = sv.case_groups_model_df.value.copy(deep=True)
-                report_data, filter_description = ccg.select_report_data(
+                report_data, filter_description = ccg.get_report_data(
                     selected_groups if len(selected_groups) > 0 else None,
                     top_group_ranks if top_group_ranks > 0 else None,
                 )

diff --git a/example_notebooks/compare_case_groups.ipynb b/example_notebooks/compare_case_groups.ipynb
@@ -116,7 +116,7 @@
     "# By top n groups\n",
     "top_groups = 4\n",
     "\n",
-    "report_data, filter_description = ccg.select_report_data(top_group_ranks=top_groups)"
+    "report_data, filter_description = ccg.get_report_data(top_group_ranks=top_groups)"
    ]
   },
   {
@@ -126,7 +126,7 @@
    "outputs": [],
    "source": [
     "# # Explain the top-ranked pattern of longest length\n",
-    "explanation = ccg.group_report(report_data, filter_description)\n",
+    "explanation = ccg.generate_group_report(report_data, filter_description)\n",
     "print(explanation)"
    ]
   }

diff --git a/toolkit/compare_case_groups/api.py b/toolkit/compare_case_groups/api.py
@@ -161,7 +161,7 @@ def get_summary_description(self) -> str:
 
         return "\n".join(description_lines)
 
-    def select_report_data(
+    def get_report_data(
         self, selected_groups=None, top_group_ranks=None
     ) -> tuple[pl.DataFrame, str]:
         filter_description = ""
@@ -177,7 +177,7 @@ def select_report_data(
             )
         return selected_df, filter_description
 
-    def group_report(
+    def generate_group_report(
         self,
         report_data: pl.DataFrame,
         filter_description=str,