-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start working on HLSL initialization lists #329
Merged
llvm-beanz
merged 4 commits into
microsoft:main
from
llvm-beanz:cbieneman/decl.init.agg
Dec 13, 2024
Merged
Start working on HLSL initialization lists #329
llvm-beanz
merged 4 commits into
microsoft:main
from
llvm-beanz:cbieneman/decl.init.agg
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one is a bit gnarly because it involves a lot of depth-first traversing of declarations, types, and initialization expresssions. Questions and suggestions on how to clarify are greatly appreciated!
llvm-beanz
force-pushed
the
cbieneman/decl.init.agg
branch
from
October 1, 2024 01:53
a51eec2
to
2da528e
Compare
pow2clk
reviewed
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the depth-first traversal well enough. I think an example would be helpful to some, but perhaps that doesn't fit in this context?
Co-authored-by: Greg Roth <[email protected]>
spall
reviewed
Oct 4, 2024
V-FEXrt
reviewed
Nov 19, 2024
bogner
approved these changes
Dec 6, 2024
V-FEXrt
approved these changes
Dec 9, 2024
spall
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is a bit gnarly because it involves a lot of depth-first traversing of declarations, types, and initialization expresssions.
Questions and suggestions on how to clarify are greatly appreciated!