Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start working on HLSL initialization lists #329

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

llvm-beanz
Copy link
Collaborator

This one is a bit gnarly because it involves a lot of depth-first traversing of declarations, types, and initialization expresssions.

Questions and suggestions on how to clarify are greatly appreciated!

This one is a bit gnarly because it involves a lot of depth-first traversing of declarations, types, and initialization expresssions.

Questions and suggestions on how to clarify are greatly appreciated!
@llvm-beanz llvm-beanz force-pushed the cbieneman/decl.init.agg branch from a51eec2 to 2da528e Compare October 1, 2024 01:53
Copy link
Member

@pow2clk pow2clk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the depth-first traversal well enough. I think an example would be helpful to some, but perhaps that doesn't fit in this context?

specs/language/declarations.tex Outdated Show resolved Hide resolved
specs/language/declarations.tex Outdated Show resolved Hide resolved
specs/language/declarations.tex Show resolved Hide resolved
specs/language/declarations.tex Outdated Show resolved Hide resolved
specs/language/declarations.tex Outdated Show resolved Hide resolved
@llvm-beanz llvm-beanz added the Design Meeting Agenda item for the design meeting label Nov 12, 2024
@llvm-beanz llvm-beanz removed the Design Meeting Agenda item for the design meeting label Dec 9, 2024
@llvm-beanz llvm-beanz merged commit 9a01d0c into microsoft:main Dec 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Accepted
Development

Successfully merging this pull request may close these issues.

5 participants