Add Basic.Decl #218
Merged
Add Basic.Decl #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This specifies more of the basic language behaviors including declarations and definitions. HLSL has some small implicit differences from C & C++ for declarations and definitions. Notably the handling of global variable declarations, which are implcitly const and external unless `static` is specified.
cbuffer and tbuffer are odd. They declare global variables that are read from a specific cbv or srv and allow defining layouts of the buffers. The name of the buffer is exposed in reflection data, but not declared as a name within the translation unit. The names of variables within the buffers are declared as global names.
coopp
reviewed
Apr 29, 2024
coopp
reviewed
Apr 29, 2024
coopp
approved these changes
Apr 29, 2024
We don't support standalone attribute declarations. We will probably need to add some new delcarations here, but we can get to that when we do.
bogner
approved these changes
May 6, 2024
damyanp
reviewed
May 6, 2024
damyanp
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specifies more of the basic language behaviors including declarations and definitions.
HLSL has some small implicit differences from C & C++ for declarations and definitions. Notably the handling of global variable declarations, which are implcitly const and external unless
staticis specified.