[0010] Allow casting to uint64_t #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@greg-lunarg FYI |
Keenuts
reviewed
Dec 5, 2023
|
I am ok with adding this to the current design. Do we want to eliminate the cast to bool to test for null pointer as this new capability lets us do this with a comparison to zero? This feels a little cleaner to me and removes the ambiguity around what might constitute a null pointer. |
|
I was considering removing the cast to bool too. I can do that. |
Keenuts
approved these changes
Dec 6, 2023
We have decided to allow casting to uint64_t. It will make create more opportunities for developers to make mistakes, but they do not have to use it. The implementation cost does not seem too high. Fixes microsoft#93
As Greg suggested, the cast to bool is no longer needed if we can cast to an int, so we removed it. This commit also adds the uint64_t cast to the pseudo class definition for BufferPointers.
|
I rebased, and updated the linked list example now that #108 has been merged. |
|
@llvm-beanz Do you have any concerns? |
llvm-beanz
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have decided to allow casting to uint64_t. It will make create
more opportunities for developers to make mistakes, but they do not
have to use it. The implementation cost does not seem too high.
Fixes #93