Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add making changes section to DeveloperGuide #1417

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

mertakman
Copy link
Contributor

This part of document covers:

  • Preparing go/src folder without falling much duplication with previous sections,
  • Making changes on go/src and small information about our approach
  • Generating new patch files and squashing changes to existing patch files
  • Rolling back changes in go/src after generating patch files

@mertakman mertakman requested a review from a team as a code owner November 20, 2024 12:08
eng/doc/DeveloperGuide.md Outdated Show resolved Hide resolved
eng/doc/DeveloperGuide.md Outdated Show resolved Hide resolved
@mertakman mertakman requested a review from qmuntal November 20, 2024 13:58
eng/doc/DeveloperGuide.md Outdated Show resolved Hide resolved
@mertakman mertakman requested review from qmuntal and dagood November 20, 2024 15:28
eng/doc/DeveloperGuide.md Show resolved Hide resolved
Copy link
Member

@dagood dagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the doc needs to get into git go-patch rebase, and I have some editing thoughts, but can save those for future PRs. Main comment is the one about cleanup.

eng/doc/DeveloperGuide.md Outdated Show resolved Hide resolved
eng/doc/DeveloperGuide.md Outdated Show resolved Hide resolved
@karianna karianna requested a review from qmuntal November 22, 2024 08:06
eng/doc/DeveloperGuide.md Outdated Show resolved Hide resolved
@mertakman mertakman requested review from dagood and qmuntal November 25, 2024 01:41
Copy link
Member

@qmuntal qmuntal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, although I think that the last section still needs some rewording (which can happen in a follow up PR).

@qmuntal qmuntal merged commit f209dfd into microsoft/main Nov 25, 2024
31 checks passed
@qmuntal qmuntal deleted the add-making-changes-guide branch November 25, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants