-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add making changes section to DeveloperGuide #1417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the doc needs to get into git go-patch rebase
, and I have some editing thoughts, but can save those for future PRs. Main comment is the one about cleanup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, although I think that the last section still needs some rewording (which can happen in a follow up PR).
This part of document covers:
go/src
folder without falling much duplication with previous sections,go/src
and small information about our approachgo/src
after generating patch files