Allow TLS 1.3 when crypto/tls/fipsonly is imported #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
requested review from
a team and
microsoft-golang-review-bot
as code owners
gdams
approved these changes
Oct 16, 2023
dagood
approved these changes
Oct 16, 2023
| - TLS_RSA_WITH_AES_256_GCM_SHA384: | ||
| + TLS_RSA_WITH_AES_256_GCM_SHA384, | ||
| + TLS_AES_128_GCM_SHA256, | ||
| + TLS_AES_256_GCM_SHA384: |
There was a problem hiding this comment.
Seeing TLS 1.3 suites bunched up with 1.2 suites, I wonder if it would make the tests more specific to separate out when 1.2 vs. 1.3 suites are expected. However: I don't know if this would actually catch anything, and it could be a significant chunk of work that never detects any problem and simply increases conflicts vs. upstream. I think we're better off waiting for upstream to reimplement this test with 1.3 in mind.
There was a problem hiding this comment.
Good point. I'll split it, this way TestBoringServerCipherSuites will also test that we are not returning TLS 1.3 ciphers in TLS 1.2 connections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to use clients and server to use TLS 1.3 when
crypto/tls/fipsonlyis imported.The major change is that
tls.TLS_CHACHA20_POLY1305_SHA256won't appear in the supported TLS 1.3 cipher suites, as it is not approved by FIPS 140-3.