Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NTStatus errors #79

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add NTStatus errors #79

wants to merge 5 commits into from
+167 −83

Conversation

mertakman
Copy link
Contributor

This PR adds NTStatus errors to the bcrypt package and updates the bcrypt function signatures to implement NTStatus.
Also contains a little patch cmd/mksyscall to truncate the windows package import for NTStatus.
Fixes: #68

qmuntal
qmuntal requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@qmuntal qmuntal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Just one comment: you should add a test to the cng package which checks that a returned error does contain a human friendly error message rather than a hex code.

internal/bcrypt/ntstatus.go Outdated Show resolved Hide resolved
@qmuntal qmuntal requested review from karianna, dagood and gdams December 18, 2024 07:26
qmuntal
qmuntal approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@qmuntal qmuntal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmuntal qmuntal qmuntal approved these changes

@karianna karianna Awaiting requested review from karianna

@dagood dagood Awaiting requested review from dagood

@gdams gdams Awaiting requested review from gdams

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error messages are formatted as Win32 error code instead of NT Status values
2 participants
@mertakman @qmuntal