Support PKCS1 with MD5SHA1 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertakman
reviewed
Nov 25, 2024
mertakman
reviewed
Nov 25, 2024
mertakman
reviewed
Nov 25, 2024
mertakman
approved these changes
Nov 25, 2024
dagood
approved these changes
Nov 25, 2024
|
For microsoft/go#1416. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MD5SHA1 hash is not supported by CNG, but the
AlgIdfield is only used to pad the signature with the hash OID, and PKCS1 has historically used a null OID for MD5SHA1.This is a special case for compatibility with TLS 1.0/1.1. We were previously falling back to Go crypto.
While here, add a check that verifies the length of the hashed message is correct for the given hash function. This was previously done by CNG, but CNG won't check this property for MD5SHA1 digests, so we need to do it ourselves. It is also a nice usability improvement, as we now return the same error message as upstream for this error condition.