Validate KEY_DATA_BLOB_VERSION1 content in ExtractHKDF #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagood
approved these changes
Oct 29, 2024
Comment on lines
158
to
161
| // KEY_DATA_BLOB_VERSION1 format is: | ||
| // cbHash uint32 // Big-endian | ||
| // hashName [cbHash]byte | ||
| // cbHashName uint32 // Big-endian | ||
| // pHashName [cbHash]byte | ||
| // key []byte // Rest of the blob |
There was a problem hiding this comment.
Where does this format come from? I'm not able to find it anywhere.
There was a problem hiding this comment.
Hmm, I don't remember where the definition came from. Maybe I just inspected the content of the data and figured it out? I'll ask the CNG team to document this payload, just as other algorithm payloads are.
karianna
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate that
KEY_DATA_BLOB_VERSION1.cbHashNamefits in the blob, else return an error instead of panic'ing.This case shouldn't happen, and I don't know how to trigger it. Yet, #70 reported a corrupted
KEY_DATA_BLOB_VERSION1when using an old Windows 10 version.