Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for RC4 #46

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Add support for RC4 #46

merged 3 commits into from
Oct 2, 2023

Conversation

qmuntal
Copy link
Member

@qmuntal qmuntal commented Sep 14, 2023 •
edited
Loading

This PR implements the necessary functions to support crypto/rc4.

New benchmark results:

goos: windows
goarch: amd64
pkg: github.com/microsoft/go-crypto-winnative/cng
cpu: Intel(R) Core(TM) i7-10850H CPU @ 2.70GHz
BenchmarkRC4_128-12      4958706               251.9 ns/op       508.17 MB/s           0 B/op          0 allocs/op
BenchmarkRC4_1K-12       1000000              1230 ns/op         832.66 MB/s           0 B/op          0 allocs/op
BenchmarkRC4_8K-12        123104              9057 ns/op         893.87 MB/s           0 B/op          0 allocs/op

@qmuntal qmuntal merged commit 968dd30 into main Oct 2, 2023
25 checks passed
@dagood dagood deleted the rc4 branch September 9, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdams gdams gdams approved these changes

@dagood dagood dagood approved these changes

@jaredpar jaredpar Awaiting requested review from jaredpar

@chsienki chsienki Awaiting requested review from chsienki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qmuntal @dagood @gdams