Use volatile write when writing to user buffer #4068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
mikeagun
previously approved these changes
Dec 3, 2024
Signed-off-by: Alan Jowett <[email protected]>
Alan-Jowett
force-pushed
the
fix_volatile_write
branch
from
557a7b2 to
fad91a1
Compare
mikeagun
approved these changes
Dec 3, 2024
mikeagun
reviewed
Dec 3, 2024
dthaler
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes a change to the
ebpf_program_get_infofunction in thelibs/execution_context/ebpf_program.cfile. The change ensures that themap_idsarray is updated using a volatile user mode pointer to prevent potential issues with compiler optimizations.libs/execution_context/ebpf_program.c: Modified theebpf_program_get_infofunction to useWriteNoFencefor updating themap_idsarray, ensuring proper handling of volatile user mode pointers.Testing
CI/CD
Documentation
No.
Installation
No.