Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spd for ebpfcore #4049

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Update spd for ebpfcore #4049

merged 2 commits into from
Nov 28, 2024

Conversation

saxena-anurag
Copy link
Contributor

@saxena-anurag saxena-anurag commented Nov 26, 2024 •
edited
Loading

Fixes #3984

Description

This PR updates the SPD file for ebpfcore. The new data was collected by running bpf_performance tests.

Before

PS C:\performance>  Release\bpf_performance_runner.exe -i tests.yml -e .sys -r -t "bpf_tail_call"
Timestamp,Test,Average Duration (ns),CPU 0 Duration (ns),CPU 1 Duration (ns),CPU 2 Duration (ns),CPU 3 Duration (ns),CPU 4 Duration (ns),CPU 5 Duration (ns),CPU 6 Duration (ns),CPU 7 Duration (ns)
2024-11-26T21:57:36-0800,bpf_tail_call,152,151,157,151,152,153,151,150,153

After

PS C:\performance>  Release\bpf_performance_runner.exe -i tests.yml -e .sys -r -t "bpf_tail_call"
Timestamp,Test,Average Duration (ns),CPU 0 Duration (ns),CPU 1 Duration (ns),CPU 2 Duration (ns),CPU 3 Duration (ns),CPU 4 Duration (ns),CPU 5 Duration (ns),CPU 6 Duration (ns),CPU 7 Duration (ns)
2024-11-26T21:59:01-0800,bpf_tail_call,101,102,102,101,102,102,101,100,101

Testing

Existing tests.

Documentation

No

Installation

No

@saxena-anurag saxena-anurag marked this pull request as ready for review November 27, 2024 16:18
@saxena-anurag saxena-anurag changed the title update spd Update spd for ebpfcore Nov 27, 2024
@Alan-Jowett Alan-Jowett added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 28, 2024
@shankarseal shankarseal added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit 3ba6c7e Nov 28, 2024
89 checks passed
@shankarseal shankarseal deleted the user/anusa/update_spd branch November 28, 2024 02:33
shankarseal pushed a commit to shankarseal/ebpf-for-windows that referenced this pull request Nov 28, 2024
@saxena-anurag @shankarseal
update spd (microsoft#4049)
3fe411d
@shankarseal shankarseal mentioned this pull request Nov 28, 2024
Merged
shankarseal added a commit that referenced this pull request Dec 2, 2024
@shankarseal @shpalani
@Alan-Jowett @saxena-anurag
Cherry pick needed commits from main to 0.20 release branch. (#4056)
cfba44d 
* expand stack to 16KB. (#4048)

* Add EBPF_LOG_MAP_OPERATION in ebpf_map find, update and delete function (#4032)

* Add EBPF_LOG_MAP_OPERATION in find,update and delete function

* expand stack to 16KB.

---------

Co-authored-by: Alan Jowett <[email protected]>
Co-authored-by: Shankar Seal <[email protected]>

* update spd (#4049)

---------

Co-authored-by: Sharmi <[email protected]>
Co-authored-by: Alan Jowett <[email protected]>
Co-authored-by: Anurag Saxena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shankarseal shankarseal shankarseal approved these changes

@Alan-Jowett Alan-Jowett Alan-Jowett approved these changes

@dthaler dthaler Awaiting requested review from dthaler dthaler is a code owner

@poornagmsft poornagmsft Awaiting requested review from poornagmsft poornagmsft is a code owner

@dv-msft dv-msft Awaiting requested review from dv-msft dv-msft is a code owner

@gtrevi gtrevi Awaiting requested review from gtrevi gtrevi is a code owner

@shpalani shpalani Awaiting requested review from shpalani shpalani is a code owner

@matthewige matthewige Awaiting requested review from matthewige matthewige is a code owner

@mtfriesen mtfriesen Awaiting requested review from mtfriesen mtfriesen is a code owner

@rectified95 rectified95 Awaiting requested review from rectified95 rectified95 is a code owner

@kumarvin123 kumarvin123 Awaiting requested review from kumarvin123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in tail call perf numbers around 10/1 - 10/2
3 participants
@saxena-anurag @Alan-Jowett @shankarseal