expand stack to 16KB for sock_addr hook. #4048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shankarseal
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
shankarseal
changed the title
saxena-anurag
approved these changes
Nov 25, 2024
Alan-Jowett
approved these changes
Nov 25, 2024
shpalani
approved these changes
Nov 25, 2024
shankarseal
added a commit
to shankarseal/ebpf-for-windows
that referenced
this pull request
Nov 27, 2024
shankarseal
added a commit
to shankarseal/ebpf-for-windows
that referenced
this pull request
Nov 28, 2024
shankarseal
added a commit
that referenced
this pull request
Dec 2, 2024
* expand stack to 16KB. (#4048) * Add EBPF_LOG_MAP_OPERATION in ebpf_map find, update and delete function (#4032) * Add EBPF_LOG_MAP_OPERATION in find,update and delete function * expand stack to 16KB. --------- Co-authored-by: Alan Jowett <[email protected]> Co-authored-by: Shankar Seal <[email protected]> * update spd (#4049) --------- Co-authored-by: Sharmi <[email protected]> Co-authored-by: Alan Jowett <[email protected]> Co-authored-by: Anurag Saxena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
The socket hook takes a lot of stack as the WFP redirect code seems to require a lot of stack. If the eBPF program attached to a socket hook invokes further helper functions that allocate memory, the stack can grow too big and sometimes cause double fault. So increasing the stack expansion limit to 16KB.
Testing
Do any existing tests cover this change? Are new tests needed?
CICD is sufficient for this.
Documentation
Is there any documentation impact for this change?
No.
Installation
Is there any installer impact for this change?
No.