Merge pull request #129 from microsoft/dilan/powershell-splitting-fix

commenting out problematic powershell qll code
microsoft · Oct 30, 2024 · fcd875d · fcd875d
2 parents 490957a + 4ff362f
commit fcd875d
Showing 1 changed file with 28 additions and 28 deletions.
diff --git a/powershell/ql/lib/semmle/code/powershell/controlflow/internal/Splitting.qll b/powershell/ql/lib/semmle/code/powershell/controlflow/internal/Splitting.qll
@@ -39,46 +39,46 @@ private module ConditionalCompletionSplitting {
     override string toString() { result = completion.toString() }
   }
 
-  private class ConditionalCompletionSplitKind extends SplitKind, TConditionalCompletionSplitKind {
-    override int getListOrder() { result = 0 }
+  // private class ConditionalCompletionSplitKind extends SplitKind, TConditionalCompletionSplitKind {
+  //   override int getListOrder() { result = 0 }
 
-    override predicate isEnabled(Ast n) { this.appliesTo(n) }
+  //   override predicate isEnabled(Ast n) { this.appliesTo(n) }
 
-    override string toString() { result = "ConditionalCompletion" }
-  }
+  //   override string toString() { result = "ConditionalCompletion" }
+  // }
 
   int getNextListOrder() { result = 1 }
 
-  private class ConditionalCompletionSplitImpl extends SplitImpl instanceof ConditionalCompletionSplit
-  {
-    ConditionalCompletion completion;
+//   private class ConditionalCompletionSplitImpl extends SplitImpl instanceof ConditionalCompletionSplit
+//   {
+//     ConditionalCompletion completion;
 
-    ConditionalCompletionSplitImpl() { this = TConditionalCompletionSplit(completion) }
+//     ConditionalCompletionSplitImpl() { this = TConditionalCompletionSplit(completion) }
 
-    override ConditionalCompletionSplitKind getKind() { any() }
+//     override ConditionalCompletionSplitKind getKind() { any() }
 
-    override predicate hasEntry(Ast pred, Ast succ, Completion c) {
-      succ(pred, succ, c) and
-      last(succ, _, completion) and
-      none() // TODO
-    }
+//     override predicate hasEntry(Ast pred, Ast succ, Completion c) {
+//       succ(pred, succ, c) and
+//       last(succ, _, completion) and
+//       none() // TODO
+//     }
 
-    override predicate hasEntryScope(Cfg::CfgScope scope, Ast succ) { none() }
+//     override predicate hasEntryScope(Cfg::CfgScope scope, Ast succ) { none() }
 
-    override predicate hasExit(Ast pred, Ast succ, Completion c) {
-      this.appliesTo(pred) and
-      succ(pred, succ, c) and
-      if c instanceof ConditionalCompletion then completion = c else any()
-    }
+//     override predicate hasExit(Ast pred, Ast succ, Completion c) {
+//       this.appliesTo(pred) and
+//       succ(pred, succ, c) and
+//       if c instanceof ConditionalCompletion then completion = c else any()
+//     }
 
-    override predicate hasExitScope(Cfg::CfgScope scope, Ast last, Completion c) {
-      this.appliesTo(last) and
-      succExit(scope, last, c) and
-      if c instanceof ConditionalCompletion then completion = c else any()
-    }
+//     override predicate hasExitScope(Cfg::CfgScope scope, Ast last, Completion c) {
+//       this.appliesTo(last) and
+//       succExit(scope, last, c) and
+//       if c instanceof ConditionalCompletion then completion = c else any()
+//     }
 
-    override predicate hasSuccessor(Ast pred, Ast succ, Completion c) { none() }
-  }
+//     override predicate hasSuccessor(Ast pred, Ast succ, Completion c) { none() }
+//   }
 }
 
 class ConditionalCompletionSplit = ConditionalCompletionSplitting::ConditionalCompletionSplit;