Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [SharePointActivityHandler] Rename type to responseType in handleActionResponse #4558

Merged

Conversation

AJIXuMuK
Copy link
Contributor

@AJIXuMuK AJIXuMuK commented Nov 2, 2023

Fixes #4557

Description

The PR fixes issue with incorrectly named property for SharePoint HandleActionResponse.

Specific Changes

  • rename type to responseType in BaseHandleActionResponse, CardViewHandleActionResponse, QuickViewHandleActionResponse and NoOpeHandleActionResponse

Testing

Full flow tests using locally served bot and SharePoint Online.

image

@AJIXuMuK AJIXuMuK requested a review from a team as a code owner November 2, 2023 13:39
@coveralls
Copy link

coveralls commented Nov 2, 2023

Pull Request Test Coverage Report for Build 6733487757

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 84.742%

Totals Coverage Status
Change from base Build 6720400283: 0.4%
Covered Lines: 20344
Relevant Lines: 22746

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 7277636 into microsoft:main Nov 2, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The bot builder framework should support SharePoint bot driven ACEs
3 participants