Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include HEAD method to http requests #6713

Merged
merged 1 commit into from
Dec 14, 2023
Merged

feat: Include HEAD method to http requests #6713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/HttpRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,12 @@ public enum HttpMethod
/// <summary>
/// Http DELETE.
/// </summary>
DELETE
DELETE,

/// <summary>
/// Http HEAD.
/// </summary>
HEAD
}

/// <summary>
Expand Down Expand Up @@ -315,7 +320,8 @@ public enum HttpMethod
}

break;
case HttpMethod.DELETE:
case HttpMethod.DELETE:
case HttpMethod.HEAD:
response = await client.SendAsync(request, cancellationToken).ConfigureAwait(false);
break;
}
Expand Down
3 changes: 2 additions & 1 deletion ...aries/Microsoft.Bot.Builder.Dialogs.Adaptive/Schemas/Actions/Microsoft.HttpRequest.schema
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
"POST",
"PATCH",
"PUT",
"DELETE"
"DELETE",
"HEAD"
],
"examples": [
"GET",
Expand Down
6 changes: 4 additions & 2 deletions tests/Microsoft.Bot.Builder.TestBot.Json/testbot.schema
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3607,7 +3607,8 @@
"POST",
"PATCH",
"PUT",
"DELETE"
"DELETE",
"HEAD"
],
"examples": [
"GET",
Expand Down Expand Up @@ -9216,7 +9217,8 @@
"POST",
"PATCH",
"PUT",
"DELETE"
"DELETE",
"HEAD"
],
"examples": [
"GET",
Expand Down
3 changes: 2 additions & 1 deletion tests/tests.schema
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3868,7 +3868,8 @@
"POST",
"PATCH",
"PUT",
"DELETE"
"DELETE",
"HEAD"
],
"examples": [
"GET",
Expand Down
Loading